| To: | Joe Perches <joe@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] 2.6.0-bk6 net/core/dev.c |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Thu, 25 Sep 2003 03:01:09 -0700 |
| Cc: | torvalds@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <1064423867.15283.11.camel@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <Pine.LNX.4.44.0309241012110.3178-100000@xxxxxxxxxxxxx> <1064423867.15283.11.camel@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 24 Sep 2003 10:17:47 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote: > On Wed, 2003-09-24 at 10:13, Linus Torvalds wrote: > > Looks sane, but wouldn't it be cleaner to put this ugly special case logic > > with casts etc in an inline function and make the code a bit more readable > > at the same time? > > I've got those. > > I've done the ((void*)1) conversions to PKT_SHARED_SKBs > and found this missing. I'll submit those separately. Send me what you have and I'll review and apply it. I haven't accomplished anything today because I've been sick, but tomorrow I should be back to full speed once more. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Patch]: IPv6 Connection Tracking, Harald Welte |
|---|---|
| Next by Date: | Re: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, David S. Miller |
| Previous by Thread: | Re: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, David S. Miller |
| Next by Thread: | [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [2/3] drivers/net/*, Joe Perches |
| Indexes: | [Date] [Thread] [Top] [All Lists] |