netdev
[Top] [All Lists]

Re: [PATCH] more const in skbuff

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH] more const in skbuff
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 20 Sep 2003 00:42:42 -0700
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030918204253.GA43611@xxxxxxxxxxxxxx>
References: <20030918102709.34211ee5.shemminger@xxxxxxxx> <20030918204253.GA43611@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 18 Sep 2003 13:42:53 -0700
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> Are you sure that atomic_read() is garaunteed to take a const pointer?
> My understanding is that an arch could in theory take a spinlock (although
> none do currently)
> 
> If it is garaunteed to take a const pointer then please fix the inline in
> include/asm-parisc/atomic.h or your patch will create a lot of warnings on
> that architecture.

I think it is, we decided a bit ago that spinlock based atomics
were a bad idea, and even with that the spinlock atomic_t implementations
do not take the lock in their atomic_read() implementation, they merely
wait to get a sample with the lock clear.

> Other than that this patch is a strict subset of the "small skbuff.[ch]
> tweaks" patch I posted here 2 weeks ago:
>   http://oss.sgi.com/projects/netdev/archive/2003-09/msg00036.html
> Never heard from davem one way or the other on that one.

Stuff often slips through the cracks from time to time, silence
doesn't necessary mean outright rejection so resend.

I'm going to apply Stephen's patch.

<Prev in Thread] Current Thread [Next in Thread>