Randy.Dunlap <rddunlap@xxxxxxxx> :
[...]
> patch_name: dscc_warnings.patch
> patch_version: 2003-09-19.11:18:03
> author: Randy.Dunlap <rddunlap@xxxxxxxx>
> description: kill 3 warnings (label, functions not used);
> product: Linux
> product_versions: 2.6.0-test5
> maintainer: Nenad Corbic <ncorbic@xxxxxxxxxxx>
?
$ less MAINTAINERS
[...]
DSCC4 DRIVER
P: François Romieu
M: romieu@xxxxxxxxxx
M: romieu@xxxxxxxx
S: Maintained
> diffstat: =
> drivers/net/wan/dscc4.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
>
> diff -Naurp ./drivers/net/wan/dscc4.c~warnings ./drivers/net/wan/dscc4.c
> --- ./drivers/net/wan/dscc4.c~warnings 2003-09-08 12:49:58.000000000
> -0700
> +++ ./drivers/net/wan/dscc4.c 2003-09-19 11:14:59.000000000 -0700
[...]
> @@ -1093,7 +1095,6 @@ done:
>
> err_disable_scc_events:
> scc_writel(0xffffffff, dpriv, dev, IMR);
> -err_free_ring:
> scc_patchl(PowerUp | Vis, 0, dpriv, dev, CCR0);
> dscc4_release_ring(dpriv);
> err_out:
The warning reminds that the call to dscc4_release_ring() is plain wrong
(hmmm... as well as calling dscc4_release_ring() in dscc4_close() *doh*).
Ok, I will fix this crap.
--
Ueimor
|