netdev
[Top] [All Lists]

Re: [PATCH] tiny af_packet.c cleanup

To: Mitchell Blank Jr <mitch@xxxxxxxxxx>
Subject: Re: [PATCH] tiny af_packet.c cleanup
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 15 Sep 2003 15:56:52 -0700
Cc: romieu@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030914112628.GD42531@xxxxxxxxxxxxxx>
References: <20030913055033.GB94744@xxxxxxxxxxxxxx> <20030913093559.A23840@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20030913080252.GE94744@xxxxxxxxxxxxxx> <20030913110353.B23840@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20030913201559.GI94744@xxxxxxxxxxxxxx> <20030914125549.A7790@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20030914112628.GD42531@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 14 Sep 2003 04:26:28 -0700
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> Francois Romieu wrote:
> > See previously posted patch. Imho the non-trivial part isn't the locking
> > itself but the fact that the first test of sk->sk_filter is done _without_
> > lock.
> 
> OK, that was what I thought was going on.  I figured the short comment (along
> with the likely()) would explain this adequately (i.e. "we're now re-checking
> under lock so we get the authorative answer") but maybe it needs more
> explaination.

When you guys decide on a final patch let me know, the semantic
parts of Mitchell's changes look perfectly fine to me.

<Prev in Thread] Current Thread [Next in Thread>