netdev
[Top] [All Lists]

Bonding driver makes bad use of ethtool

To: bonding-devel@xxxxxxxxxxxxxxxxxxxxx, Amir Noam <amir.noam@xxxxxxxxx>
Subject: Bonding driver makes bad use of ethtool
From: Matthew Wilcox <willy@xxxxxxxxxx>
Date: Fri, 12 Sep 2003 15:27:30 +0100
Cc: netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
ethtool is being abused by the bonding driver.  ifenslave is passing
in which ABI version it wants to use via the ETHTOOL_GDRVINFO call.
This cannot continue in the ethtool_ops scheme, and it's my opinion this
shouldn't've been done in the first place.

I suggest a new ioctl to set your ABI version and delete this bad use
of ETHTOOL_GDRVINFO.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

<Prev in Thread] Current Thread [Next in Thread>