Re: ipt_physdev.c alignment problems on parisc64

[jamal <hadi@xxxxxxxxxx>]

Harald,

Could you not resolve all the ifindices of the said ppp+ interfaces
at rule installation time and do an integer compare instead?

cheers,
jamal

On Fri, 2003-09-05 at 11:31, Harald Welte wrote:

> > 
> > Please, just remove the super-silly memcmp() optimization in
> > the ipt_physdev.c code.
> 
> Dave, the respective code in ipt_physdev.c seems to be copied from
> the ip_tables.c interface name match (which definitely has the same
> alignment issues, btw).
> 
> The problem is that it is _not_ a simple reimplementation of memcmp(),
> but a mask-compare.
> 
> People can do stuff like "-i ppp+", meaning that traffic from all
> interfaces called "ppp<WHATEVER>" are matched.