netdev
[Top] [All Lists]

[PATCH] ipv4 -- proc_net_fops_create

To: David Miller <davem@xxxxxxxxxx>
Subject: [PATCH] ipv4 -- proc_net_fops_create
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 11 Sep 2003 15:43:57 -0700
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
Use proc_net_fops_create it is cleaner.

diff -Nru a/net/ipv4/proc.c b/net/ipv4/proc.c
--- a/net/ipv4/proc.c   Thu Sep 11 15:36:06 2003
+++ b/net/ipv4/proc.c   Thu Sep 11 15:36:06 2003
@@ -240,20 +240,12 @@
        int rc = 0;
        struct proc_dir_entry *p;
 
-       p = create_proc_entry("netstat", S_IRUGO, proc_net);
-       if (!p)
+       if (!proc_net_fops_create("netstat", S_IRUGO, &netstat_seq_fops))
                goto out_netstat;
-       p->proc_fops = &netstat_seq_fops;
-
-       p = create_proc_entry("snmp", S_IRUGO, proc_net);
-       if (!p)
+       if (!proc_net_fops_create("snmp", S_IRUGO, &snmp_seq_fops))
                goto out_snmp;
-       p->proc_fops = &snmp_seq_fops;
-
-       p = create_proc_entry("sockstat", S_IRUGO, proc_net);
-       if (!p)
+       if (!proc_net_fops_create("sockstat", S_IRUGO, &sockstat_seq_fops))
                goto out_sockstat;
-       p->proc_fops = &sockstat_seq_fops;
 out:
        return rc;
 out_sockstat:

<Prev in Thread] Current Thread [Next in Thread>