Re: [BK PATCH 2.6] repost, fix sysctl breakage during network device renaming, for ipv4

[Dan Aloni <da-x@xxxxxxx>]

On Mon, Sep 01, 2003 at 11:31:43AM -0700, David S. Miller wrote:
> On Mon, 1 Sep 2003 19:55:59 +0300
> Dan Aloni <da-x@xxxxxxx> wrote:
> 
> > The private copy of strdup() is something that I'd also wouldn't
> > want, but I don't have much choice. Please read a recent 
> > thread in lkml regarding strdup() consolidation.
> 
> Ugh, I'm afraid to look...  I guess the controversy is
> over the allocation function, what GFP_* flags it should
> use etc.?

Yes, this is the one reason against consolidation, though
I don't know why anyone would want to call strdup() from a 
context other than GPF_KERNEL. Copying strings around in the 
kernel is done as a result of userspace interaction.
 
> For now just call the thing in your patch netdev_name_dup() or
> something like that.  I can't handle having something named
> "strdup()" in there :-)

Sure, I'll do it and resend.

-- 
Dan Aloni
da-x@xxxxxxx