netdev
[Top] [All Lists]

100 network limit

To: netdev@xxxxxxxxxxx
Subject: 100 network limit
From: Anton Blanchard <anton@xxxxxxxxx>
Date: Fri, 29 Aug 2003 04:00:19 +1000
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
Hi,

We hit the 100 network naming limit :) Yes the comment is correct, we
need to fix the algorithm. dev_base_lock really starts to show up
(eg in dev_get_by_index), especially when doing IO to raw sockets
(does every packet to a raw socket result in a dev_get_by_index? Couldnt
we embed a pointer to the device in the socket?)

Anyway as a short term fix Jamal suggested making a sysctl for this
maximum. If fixing this all properly is out of the question for 2.6,
would the sysctl approach be satisfactory? The other option is to just
bump the limit and recognise that the user is on his own if performance
sucks.

Anton

diff -ru gr14/net/core/dev.c gr14_work/net/core/dev.c
--- gr14/net/core/dev.c 2003-08-18 13:40:43.000000000 -0500
+++ gr14_work/net/core/dev.c    2003-08-28 12:56:45.000000000 -0500
@@ -630,9 +630,9 @@
                return -EINVAL;
 
        /*
-        * If you need over 100 please also fix the algorithm...
+        * If you need over 200 please also fix the algorithm...
         */
-       for (i = 0; i < 100; i++) {
+       for (i = 0; i < 200; i++) {
                snprintf(buf, sizeof(buf), name, i);
                if (!__dev_get_by_name(buf)) {
                        strcpy(dev->name, buf);

<Prev in Thread] Current Thread [Next in Thread>