netdev
[Top] [All Lists]

Re: [PATCH 2.6.0-test4][NET] 3c509.c: remove device.name field

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH 2.6.0-test4][NET] 3c509.c: remove device.name field
From: Vinay K Nallamothu <vinay-rc@xxxxxxxxxxxxxx>
Date: 24 Aug 2003 17:55:40 +0530
Cc: netdev@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20030824034735.534b8c68.davem@xxxxxxxxxx>
References: <1061644409.1141.18.camel@xxxxxxxxxxxxxxxxxxxxxxx> <20030824034735.534b8c68.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Hi Dave,

On Sun, 2003-08-24 at 16:17, David S. Miller wrote:
> On 23 Aug 2003 18:43:29 +0530
> Vinay K Nallamothu <vinay-rc@xxxxxxxxxxxxxx> wrote:
> 
> > This patch removes the device name field which is no longer present.
> 
> This doesn't look like the right fix.  You can't just
> delete these lines, you should rather replace them with
> accesses to whatever the MCA device struct name field is.
> 
> 
Pls find the updated patch (hopefully right this time) below:

Thanks
vinay

--- linux-2.6.0-test4/drivers/net/3c509.c       2003-08-23 13:14:30.000000000 
+0530
+++ linux-2.6.0-test4-nvk/drivers/net/3c509.c   2003-08-24 17:51:19.000000000 
+0530
@@ -629,8 +629,8 @@
                           el3_mca_adapter_names[mdev->index], slot + 1);
 
                /* claim the slot */
-               strncpy(device->name, el3_mca_adapter_names[mdev->index],
-                               sizeof(device->name));
+               strncpy(mdev->name, el3_mca_adapter_names[mdev->index],
+                               sizeof(mdev->name));
                mca_device_set_claim(mdev, 1);
 
                if_port = pos4 & 0x03;


<Prev in Thread] Current Thread [Next in Thread>