Re: [PATCH] convert ircomm to seq_file interface

[Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>]

On Tue, Aug 19, 2003 at 09:20:09PM -0700, David S. Miller wrote:
> On Mon, 18 Aug 2003 13:09:23 -0700
> Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Mon, Aug 18, 2003 at 12:31:42PM -0700, Stephen Hemminger wrote:
> > > Convert ircomm /proc interface to seq_file.
> > > 
> > > Note: don't need spin_lock_irq because list is not ever locked
> > > from inside interrupt context.
> > 
> >     I don't agree with this change.
> 
> I'll let you guys work this one out.  Let me know when a
> final version of the patch is ready.

        Oh, that's fairly simple. You just need to revert the
spin_lock() to a spin_lock_irqsave().
        By the way, I would prefer Stephen to not rock the boat when
it come to locking, I know that the locking of the IrDA stack is still
"fragile" in areas.
        Have fun...

        Jean