Re: (usagi-core 15040) [PATCH] IPv6: Protect proxied addresses against DAD

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <Pine.LNX.4.44.0308201449550.756-200000@xxxxxxxxxxxxxxx> (at Wed, 20 
Aug 2003 15:58:08 +0300 (EEST)), Ville Nuorvala <vnuorval@xxxxxxxxxx> says:

> > >           if (in6_dev && in6_dev->cnf.forwarding &&
> > > -             (addr_type & IPV6_ADDR_UNICAST) &&
> > > +             (addr_type & IPV6_ADDR_UNICAST ||
> > > +              addr_type == IPV6_ADDR_ANY) &&
> > >               pneigh_lookup(&nd_tbl, &msg->target, dev, 0)) {
> > >                   int inc = ipv6_addr_type(daddr)&IPV6_ADDR_MULTICAST;
> > >
> >
> > I believe we don't need this chunk.
> 
> No, it is needed. Normal neighbor solicitations are sent using a unicast
> source address, but DAD probes are sent using the unspecified address as
> source.

Oops, sorry, I read it as it were "ANYCAST."
I agree.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA