netdev
[Top] [All Lists]

Re: [PATCH] Change MAC without bringing interface down

To: Tommi Virtanen <tv@xxxxxxxxxx>
Subject: Re: [PATCH] Change MAC without bringing interface down
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 18 Aug 2003 04:19:11 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20030818091312.GA4889@lapdog>
References: <20030818091312.GA4889@lapdog>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 18 Aug 2003 12:13:12 +0300
Tommi Virtanen <tv@xxxxxxxxxx> wrote:

>       Here's a patch that
> 
>       1. makes eth_header_cache_update also update the source MAC in
>          hh_cache.
> 
>       2. adds a NETDEV_CHANGEADDR notifier in net/core/neighbour.c
>          that walks through all the neighbour entries and updates
>          the hh_cache's for all the neighbour entries related to
>          given device.
> 
>       3. adds neighbour_init() to allow registration of said notifier.

I would suggest to fix this by instead flushing the hh
entries (just like neigh_destroy() does).

This way, we don't have to fix up every single header cache
implementation, that's painful :(

<Prev in Thread] Current Thread [Next in Thread>