netdev
[Top] [All Lists]

Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] (10/11) netrom - convert /proc interface to seq_file
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Fri, 15 Aug 2003 18:12:17 -0300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Jeroen Vreeken <pe1rxq@xxxxxxxxx>, linux-hams@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030814113025.2b40be14.shemminger@xxxxxxxx>
Organization: Conectiva S.A.
References: <20030813154635.376df59b.shemminger@xxxxxxxx> <20030814172539.GD1785@xxxxxxxxxxxxxxxx> <20030814113025.2b40be14.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.4i
Em Thu, Aug 14, 2003 at 11:30:25AM -0700, Stephen Hemminger escreveu:
> On Thu, 14 Aug 2003 14:25:39 -0300
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> wrote:
> > <nitpick> why not just one seq_printf call? </nitpick>
> 
> ax2asc() returns a pointer to static buffer.

argh :-\ Even if only for correctness shouldn't it receive a buffer, like
snprintf, etc?

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>