Re: [RFT][PATCH] cleanup net/atm/br2684.c

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Mon, 11 Aug 2003 14:58:57 -0700
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> You might also want to send this patch to the linux-atm mailing list:
>   linux-atm-general@xxxxxxxxxxxxxxxxxxxxx
> Unfortunately you need to subscribe to post.
>   http://lists.sourceforge.net/lists/listinfo/linux-atm-general
> 
> Not sure how many ATM users are following 2.6 yet though.  I might be
> able to give it a spin soon.
> 
> > -                   unregister_netdev(&brdev->net_dev);
> > -                   kfree(brdev);
> > +                   unregister_netdev(brdev->net_dev);
> > +                   kfree(brdev->net_dev);
> 
> Mmmm.. I see this snippet in your diff in multiplce places and it looks
> wrong.  Where does the "brdev" structure get freed now?
> 
> -Mitch
The brdev structure is contained inside the allocation of net_device,
this is how all the ether and other devices do it.

net_dev   -->+-------------------+
             | network_device    |
             +-------------------+
             |/// padding ///////|
             +-------------------+
priv      -->|     brdev         |
             +-------------------+