netdev
[Top] [All Lists]

Re: [PATCH] IPV6: strategy hander for net.ipv6.conf.*.forwarding (is Re:

To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] IPV6: strategy hander for net.ipv6.conf.*.forwarding (is Re: problem setting net.ipvX.conf.all.forwarding via sysctl() system call)
From: Jan Oravec <jan.oravec@xxxxxxx>
Date: Fri, 8 Aug 2003 11:37:04 +0200
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030808.175030.19527061.yoshfuji@xxxxxxxxxxxxxx>
References: <20030803154427.GA12926@xxxxxxxxxx> <20030808.175030.19527061.yoshfuji@xxxxxxxxxxxxxx>
Reply-to: Jan Oravec <jan.oravec@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Aug 08, 2003 at 05:50:30PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:

> +     *valp = new;
> +     if (valp != &ipv6_devconf.forwarding &&
> +         valp != &ipv6_devconf_dflt.forwarding) {
> +             struct inet6_dev *idev = (struct inet6_dev *)table->extra1;
> +             if (!idev)
> +                     return -ENODEV;
> +             addrconf_forward_change(idev);
> +     }
> +     return 0;
> +}

Shouldn't we set ipv6_devconf_dflt.forwarding and call
addr_forward_change(NULL) in case that valp==&ipv6_devconf.forwarding?


-- 
Jan Oravec                           XS26 coordinator
6COM s.r.o.                          'Access to IPv6'
http://www.6com.sk                   http://www.xs26.net

<Prev in Thread] Current Thread [Next in Thread>