Re: [PATCH] tun driver not cleaning up on module remove

netdev

Re: [PATCH] tun driver not cleaning up on module remove

To:	Stephen Hemminger <shemminger@xxxxxxxx>
Subject:	Re: [PATCH] tun driver not cleaning up on module remove
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Thu, 7 Aug 2003 15:59:01 -0700
Cc:	bellucda@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<20030807154524.4794ad45.shemminger@xxxxxxxx>
References:	<200308051630.28552.bellucda@xxxxxxxxxx> <20030805090647.691daa7e.shemminger@xxxxxxxx> <200308051910.55823.bellucda@xxxxxxxxxx> <20030807154524.4794ad45.shemminger@xxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Thu, 7 Aug 2003 15:45:24 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> This should fix module unload issues with tun driver in 2.6-test2.
> Driver was not cleaning up it's devices on module exit.

The fix looks correct, but the dev->init test looks kind of grotty.

Why not add a list_head to tun_struct, and then maintain a list rooted
in 'tun.c:tun_alldevs_list', then iterate over that in the
module_exit() routine?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] tun driver not cleaning up on module remove, Stephen Hemminger Re: [PATCH] tun driver not cleaning up on module remove, David S. Miller <= [PATCH] tun driver use private linked list., Stephen Hemminger Re: [PATCH] tun driver use private linked list., David S. Miller Re: [PATCH] tun driver use private linked list., Max Krasnyansky Re: [PATCH] tun driver use private linked list., Stephen Hemminger

Previous by Date:	Re: Ethernet bridge performance, Robert Olsson
Next by Date:	[bk patches] 2.6.x net driver updates, Jeff Garzik
Previous by Thread:	[PATCH] tun driver not cleaning up on module remove, Stephen Hemminger
Next by Thread:	[PATCH] tun driver use private linked list., Stephen Hemminger
Indexes:	[Date] [Thread] [Top] [All Lists]