Re: [PATCH] repairing rtcache killer

[kuznet@xxxxxxxxxxxxx]

Hello!

>  if (in_hit < in_slow_tot) 
>       ip_rt_gc_elasticity2 = 1;
>  else 
>          ip_rt_gc_elasticity2 = 2*ip_rt_gc_elasticity;
> 
>  would have been cleaner

It is _much_ cleaner.


> but maybe it's not worth it.

Well, it is wrong before all. With default settings for number of flows
at pktgen you will get always 1 not depending on length of flow at all.
No hits just because cache is too small. See? It is the problem.

Alexey