| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: e100 "Ferguson" release |
| From: | David Brownell <david-b@xxxxxxxxxxx> |
| Date: | Sun, 03 Aug 2003 20:09:10 -0700 |
| Cc: | Ben Greear <greearb@xxxxxxxxxxxxxxx>, jgarzik@xxxxxxxxx, scott.feldman@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20030803003239.4257ef24.davem@xxxxxxxxxx> |
| References: | <C6F5CF431189FA4CBAEC9E7DD5441E010222927D@xxxxxxxxxxxxxxxxxxxxxx> <3F2CA65F.8060105@xxxxxxxxx> <3F2CBA71.2070503@xxxxxxxxxxxxxxx> <20030803003239.4257ef24.davem@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 |
David S. Miller wrote: Although I have not tried this latest patch, the existing e100 and e1000 in 2.4.21 seldom seem to return true to this method: netif_queue_stopped(odev), even when the next hard_start_xmit() call fails.Returning an error from hard_start_xmit() from normal ethernet drivers is, frankly, a driver bug and should never happen. What's "normal" mean? With the current USB stack, network adapters tend to need memory allocations there. Those can fail, though it seems that's not very common. Doesn't seem like a bug, for all that I'd rather see the those paths be zero-alloc in 2.7. - Dave |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: TOE brain dump, Larry McVoy |
|---|---|
| Next by Date: | Re: e100 "Ferguson" release, David S. Miller |
| Previous by Thread: | Re: e100 "Ferguson" release, David S. Miller |
| Next by Thread: | Re: e100 "Ferguson" release, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |