netdev
[Top] [All Lists]

Re: [PATCH] ethtool_ops rev 4

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] ethtool_ops rev 4
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 1 Aug 2003 16:19:37 -0700
Cc: willy@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <3F2AF525.3000605@xxxxxxxxx>
References: <20030801150232.GV22222@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20030801154021.GA7696@xxxxxxx> <20030801154656.GW22222@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20030801162536.GA18574@xxxxxxx> <20030801132037.3f3542ae.davem@xxxxxxxxxx> <3F2AE91D.5090705@xxxxxxxxx> <20030801153255.204baf66.davem@xxxxxxxxxx> <3F2AF141.2010308@xxxxxxxxx> <20030801160136.3342c5cc.davem@xxxxxxxxxx> <3F2AF525.3000605@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 01 Aug 2003 19:17:57 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> Solution #2 chooses to create a tiny bit more 
> merge-to-mainline pain, but also keeps the mainline kernel drivers more 
> clean.

You don't need DO_ETHTOOL_OPS and thus the merge-to-mainline pain
at all if you do something like:

1) SET_ETHDEV_OPS() also overrides the ->do_ioctl() setting to
   a kcompat_netdev_ioctl() one, but remembers the original pointer
   somewhere.

2) kcompat_netdev_ioctl() does the things DO_ETHTOOL_OPS would
   have done, failing that it calls the saved ->do_ioctl() pointer.

<Prev in Thread] Current Thread [Next in Thread>