netdev
[Top] [All Lists]

[PATCH] Eliminate MOD_ from wanrouter

To: Nenad Corbic <ncorbic@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH] Eliminate MOD_ from wanrouter
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Fri, 18 Jul 2003 13:35:12 -0700
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
Wan router register/unregister doesn't need MOD_INC/MOD_DEC because it
can't be unloaded as long as it's symbols are in use by the calling module.

Patch against 2.6.0-test1

diff -Nru a/net/wanrouter/wanmain.c b/net/wanrouter/wanmain.c
--- a/net/wanrouter/wanmain.c   Fri Jul 18 13:20:48 2003
+++ b/net/wanrouter/wanmain.c   Fri Jul 18 13:20:48 2003
@@ -305,7 +305,6 @@
        wandev->dev  = NULL;
        wandev->next = wanrouter_router_devlist;
        wanrouter_router_devlist = wandev;
-        MOD_INC_USE_COUNT;     /* prevent module from unloading */
        return 0;
 }
 
@@ -350,7 +349,6 @@
                wanrouter_router_devlist = wandev->next;
 
        wanrouter_proc_delete(wandev);
-        MOD_DEC_USE_COUNT;
        return 0;
 }
 


<Prev in Thread] Current Thread [Next in Thread>