netdev
[Top] [All Lists]

Re: [PATCH] [1/2] kernel error reporting (revised)

To: Jim Keniston <jkenisto@xxxxxxxxxx>
Subject: Re: [PATCH] [1/2] kernel error reporting (revised)
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Fri, 18 Jul 2003 11:53:06 +1000 (EST)
Cc: Andrew Morton <akpm@xxxxxxxx>, <davem@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <jgarzik@xxxxxxxxx>, <alan@xxxxxxxxxxxxxxxxxxx>, <rddunlap@xxxxxxxx>, <kuznet@xxxxxxxxxxxxx>
In-reply-to: <3F16F54C.949A9299@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 17 Jul 2003, Jim Keniston wrote:

> 3. Given the above, what should the evlog.c caller do when
> kernel_error_event_iov() returns -EINPROGRESS?
> a. Nothing.  Figure the packet will probably get logged.
> b. Just to be safe, report it via printk, the same way we report dropped
> packets.
> We currently do (a).  (b) would mean that every event logged from IRQ
> context would be cc-ed to printk.

I don't think this irq detection logic should be added at all here, let 
the caller reschedule its logging if running in irq context.


- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>