| To: | James Morris <jmorris@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 11 Jul 2003 22:41:42 -0700 |
| Cc: | jkenisto@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, akpm@xxxxxxxx, jgarzik@xxxxxxxxx, alan@xxxxxxxxxxxxxxxxxxx, rddunlap@xxxxxxxx, kuznet@xxxxxxxxxxxxx |
| In-reply-to: | <Mutt.LNX.4.44.0307120135120.21806-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <3F0DB9A5.23723BE1@xxxxxxxxxx> <Mutt.LNX.4.44.0307120135120.21806-100000@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 12 Jul 2003 01:37:44 +1000 (EST) James Morris <jmorris@xxxxxxxxxxxxxxxx> wrote: > Indeed, the kernel socket buffer fills up. > > I think this needs to be addressed in the netlink code, per the patch > below. ... > + /* Don't bother queuing skb if kernel socket has no input function */ > + if (nlk->pid == 0 && !nlk->data_ready) > + goto no_dst; > + Oops, turns out this doesn't work. data_ready is never NULL, look at how netlink_kernel_create() works. Also, the broadcast case probably needs to be handled too? As an aside, to be honest what's so wrong with the socket receive buffer filling up? The damage is limited to the receive buffer size of the kernel netlink socket, but that's it. |
| Previous by Date: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting, David S. Miller |
|---|---|
| Next by Date: | Re: 2.5.74 X.25+LAPB still kills the kernel, David S. Miller |
| Previous by Thread: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting, David S. Miller |
| Next by Thread: | Re: [PATCH - RFC] [1/2] 2.6 must-fix list - kernel error reporting, James Morris |
| Indexes: | [Date] [Thread] [Top] [All Lists] |