Hello!
> I can't see any reason to be mucking about with the device promiscuity
> on NETDEV_DOWN and NETDEV_UP events in the first place.
I do not remember why protocols (i.e. IP) withdraw multicast lists
on device down too. :-)
> The attached
> patch seems to fix all the cases I can think of.
I think it is right.
Actually, if to follow the tradition, we could do the same thing as IP does
(remembering that mc record is not loaded), but it looks really useless.
Dave, the patch looks OK.
Alexey
PS. Wow!
X-MIME-Autoconverted: from 8bit to quoted-printable by oss.sgi.com id
h61MHp2x016322
X-MIME-Autoconverted: from quoted-printable to 8bit by devserv.devel.redhat.com
id h61MI0K27113
Mime-Version: 1.0 (modified by Mew)
Content-Transfer-Encoding: quoted-printable (modified by Mew)
All three agents (oss, redhat and your mailer) are damn smart. Rare mail
will pass through this uncorrupted, I guess. :-)
|