| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] network hotplug via class_device/kobject |
| From: | Krzysztof Halasa <khc@xxxxxxxxx> |
| Date: | 15 Jun 2003 21:32:38 +0200 |
| Cc: | shemminger@xxxxxxxx, greg@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20030615.005055.55726223.davem@xxxxxxxxxx> |
| References: | <20030613164119.15209934.shemminger@xxxxxxxx> <20030615.005055.55726223.davem@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
"David S. Miller" <davem@xxxxxxxxxx> writes:
> Paranoid about some driver doing something like:
> rtnl_lock(); register_netdevice(); unregister_netdevice();
> rtnl_unlock() BOOM
>
> These sorts of turds exist at least in two places:
>
> 1) drivers/net/wan/comx.c
> 2) drivers/net/wan/hdlc_fr.c
>
> But it is pretty clear that these two drivers have been
> tried by nobody in recent years. They both call into
> {un,}register_netdevice without the RTNL semaphore held.
Not sure about 1), but 2) calls (un)register_netdevice() with rtnl_lock,
from ioctl.
--
Krzysztof Halasa
Network Administrator
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] switch iph5526_probe to initcalls, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [patch] IPV6: Refcount leaks in udpv6_connect(), Ville Nuorvala |
| Previous by Thread: | Re: [PATCH] network hotplug via class_device/kobject, Francois Romieu |
| Next by Thread: | [PATCH] [XFRM] xfrm_alloc_spi() always selected minspi, YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |