netdev
[Top] [All Lists]

Re: [PATCH] network hotplug via class_device/kobject

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] network hotplug via class_device/kobject
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Sun, 15 Jun 2003 12:45:19 +0200
Cc: khc@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20030615.005055.55726223.davem@xxxxxxxxxx>; from davem@xxxxxxxxxx on Sun, Jun 15, 2003 at 12:50:55AM -0700
References: <20030613164119.15209934.shemminger@xxxxxxxx> <20030615.005055.55726223.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
David S. Miller <davem@xxxxxxxxxx> :
[rtnl_lock() and register_netdevice()]
>    Paranoid about some driver doing something like:
>       rtnl_lock(); register_netdevice(); unregister_netdevice(); 
> rtnl_unlock() BOOM
> 
> These sorts of turds exist at least in two places:
> 
> 1) drivers/net/wan/comx.c
> 2) drivers/net/wan/hdlc_fr.c
> 
> But it is pretty clear that these two drivers have been
> tried by nobody in recent years.  They both call into

It's pretty clear but it's false :o)

> {un,}register_netdevice without the RTNL semaphore held.

There is a maintainer for 2):
GENERIC HDLC DRIVER, N2 AND C101 DRIVERS
P:      Krzysztof Halasa
M:      khc@xxxxxxxxx
W:      http://hq.pm.waw.pl/hdlc/
S:      Maintained

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>