| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [BUG] drivers/net/ioc3_eth.c in 2.5 |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Mon, 9 Jun 2003 13:12:24 -0400 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, ralf@xxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20030609101018.0ca2e1f9.shemminger@xxxxxxxx> |
| References: | <20030606161658.1f01b8f9.shemminger@xxxxxxxx> <20030607.013010.116359540.davem@xxxxxxxxxx> <20030609101018.0ca2e1f9.shemminger@xxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Mon, Jun 09, 2003 at 10:10:18AM -0700, Stephen Hemminger wrote:
> Looks like the right fix is:
> --- ioc3-eth.c.orig 2003-06-09 10:05:45.000000000 -0700
> +++ ioc3-eth.c 2003-06-09 10:04:45.000000000 -0700
> @@ -1614,6 +1614,7 @@ static void __devexit ioc3_remove_one (s
> struct ioc3 *ioc3 = ip->regs;
>
> iounmap(ioc3);
> + unregister_netdev(dev);
> pci_release_regions(pdev);
> kfree(dev);
> }
You want to unregister before iounmap.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [BUG] drivers/net/ioc3_eth.c in 2.5, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.5.70] Add release_netdev -- hook for sysfs/net device cleanup, David S. Miller |
| Previous by Thread: | Re: [BUG] drivers/net/ioc3_eth.c in 2.5, David S. Miller |
| Next by Thread: | Re: [BUG] drivers/net/ioc3_eth.c in 2.5, Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |