netdev
[Top] [All Lists]

Re: [PATCH 2.5.70] tulip/xircom initialization bug

To: shemminger@xxxxxxxx
Subject: Re: [PATCH 2.5.70] tulip/xircom initialization bug
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 04 Jun 2003 21:17:50 -0700 (PDT)
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030604112136.7b8e2cf4.shemminger@xxxxxxxx>
References: <20030604112136.7b8e2cf4.shemminger@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Stephen Hemminger <shemminger@xxxxxxxx>
   Date: Wed, 4 Jun 2003 11:21:36 -0700

   By inspection of device initialization code, this driver
   unregister's the net device in the error path even though the
   register_netdevice never succeeded.
   
This is fully legal, unregister_netdevice() checks for existence of
the netdev in the device list and if not found it returns an error.

This severely simplifies error path handling while we convert all
these drivers away from init_etherdev().

<Prev in Thread] Current Thread [Next in Thread>