netdev
[Top] [All Lists]

[PATCH 2.5.70] tulip/xircom initialization bug

To: "David S. Miller" <davem@xxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: [PATCH 2.5.70] tulip/xircom initialization bug
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 4 Jun 2003 11:21:36 -0700
Cc: netdev@xxxxxxxxxxx
Organization: Open Source Development Lab
Sender: netdev-bounce@xxxxxxxxxxx
By inspection of device initialization code, this driver unregister's the net 
device
in the error path even though the register_netdevice never succeeded.

Compiles, but don't have the hardware.

diff -Nru a/drivers/net/tulip/xircom_tulip_cb.c 
b/drivers/net/tulip/xircom_tulip_cb.c
--- a/drivers/net/tulip/xircom_tulip_cb.c       Wed Jun  4 11:18:44 2003
+++ b/drivers/net/tulip/xircom_tulip_cb.c       Wed Jun  4 11:18:44 2003
@@ -648,7 +648,6 @@
        pci_set_drvdata(pdev, NULL);
        pci_release_regions(pdev);
 err_out_free_netdev:
-       unregister_netdev(dev);
        kfree(dev);
        return -ENODEV;
 }

<Prev in Thread] Current Thread [Next in Thread>