Re: [PATCH] remove sdla from setup.c

[Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>]

Em Thu, May 29, 2003 at 02:57:49AM -0700, David S. Miller escreveu:
>    From: Christoph Hellwig <hch@xxxxxx>
>    Date: Wed, 28 May 2003 13:06:58 +0200
> 
>    sdla had calls from both Space.c and setup.c.  Leave the Space.c one
>    alone as per previous discussion but move over the setup.c one to
>    initcalls.  (and remove the prototype for a third one from setup.c!)
>    
> Looks ok, applied.
> 
> Some of this wan driver stuff is so crappy :(

Crappy? You are being nice...

What about this:

void lock_adapter_irq(spinlock_t *lock, unsigned long *smp_flags)
{
        spin_lock_irqsave(lock, *smp_flags);
}

Why the hell do we need a bogus wrapper for something so standard?

:-(

- Arnaldo