netdev
[Top] [All Lists]

Re: Mail delivery failed: returning message to sender

To: kuznet@xxxxxxxxxxxxx
Subject: Re: Mail delivery failed: returning message to sender
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 20 May 2003 19:31:19 -0700 (PDT)
Cc: rmk@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200305210222.GAA13659@xxxxxxxxxxxxx>
References: <20030520.175553.35669773.davem@xxxxxxxxxx> <200305210222.GAA13659@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: kuznet@xxxxxxxxxxxxx
   Date: Wed, 21 May 2003 06:22:10 +0400 (MSD)
   
   > Russel, please retest using this patch.  This piece of
   > code needs to be audited further.
   
   Relax, it is right now.
   
   I hope it is the only place where route is copied as whole.

I explicitly zeroed out child and xfrm in my final version.
These should never be non-NULL, it is pure paranoia on my part :-)

IP6 makes this more intelligently using ip6_route_copy() function.
We should probably make similar beast for ipv4 just for clarity's
sake.

<Prev in Thread] Current Thread [Next in Thread>