netdev
[Top] [All Lists]

Re: comment about struct tcp_tw_bucket in struct sock

To: olh@xxxxxxx
Subject: Re: comment about struct tcp_tw_bucket in struct sock
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 14 May 2003 12:17:27 -0700 (PDT)
Cc: marcelo@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030514080043.GA2575@xxxxxxx>
References: <20030513210541.GA4415@xxxxxxx> <20030513.163150.28800008.davem@xxxxxxxxxx> <20030514080043.GA2575@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Olaf Hering <olh@xxxxxxx>
   Date: Wed, 14 May 2003 10:00:43 +0200

    On Tue, May 13, David S. Miller wrote:
   
   > It's documented in tcp.h already.
   
   True, but not in struct sock.

When you edit the layout of struct sock you assume
the full responsibility that you might be breaking
something that uses struct sock.  This includes
third party modules.

You shouldn't be making changing to it lightly.  How this made TCP
blow up is the negative feedback you get for trying to change struct
sock ;-)

<Prev in Thread] Current Thread [Next in Thread>