netdev
[Top] [All Lists]

Re: Where is netif_rx() not safe to use?

To: Jason Lunz <lunz@xxxxxxxxxxxx>
Subject: Re: Where is netif_rx() not safe to use?
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 12 May 2003 11:44:34 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <slrnbbveq6.321.lunz@xxxxxxxxxxxxxx>
References: <3ebfa567b38e59.35614148@notright> <20030512145943.GB27111@xxxxxxx> <slrnbbveq6.321.lunz@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Mon, May 12, 2003 at 03:16:55PM +0000, Jason Lunz wrote:
> jgarzik@xxxxxxxxx said:
> >> I'd like to know if there are situations where netif_rx() is not safe to 
> >> use. 
> >> For example, is it safe to call from a timer or from dev->poll()?
> > 
> > Sure, that's fine.
> 
> from dev->poll()? It could work, but that's abusing the napi design.
> netif_rx() is for non-napi drivers.  If a dev has a ->poll() method, it
> should use netif_receive_skb().

agreed.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>