Re: acenic lockup

[Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>]

Hello!

>    Its stuck there and never coming out. Alexey: I have a feeling you
>    wrote this code, is that correct? :)

Yes, I did. I am not sure about barriers, I stopped attempts
to understand this long ago. Anyway, intel does not have anything
to put here, mb() at side updating pointer looks enough.
 

There is a real ugly BUG in the driver, ace_watchdog():

        } else {
                printk(KERN_DEBUG "%s: BUG... transmitter died. Kicking it.\n",
                       dev->name);
#if 0
                netif_wake_queue(dev);
#endif
        }

(#if is from my local tree). I remember we discussed this with Dave
and he was very angry about this flaw shared by most of drivers and, seems,
did not eat this fix.

So, if you see the message, it is surely this bug.


Alexey