Em Thu, May 01, 2003 at 10:01:19PM +1000, Rusty Russell escreveu:
> But before we redesign module architecture from scratch, let's look at
> a solution with what we do have (assuming Linus takes my damn
> __module_get() patch some day, see below).
Linus took the __module_get patch, I even used it in redesigning the way
struct sock and struct socket are handled in response to Max Krasnyansky
> There are 70 calls to dev_hold() in the kernel. The vast majority of
> them already have a reference, they just want another one: dev_hold()
> can do __module_get().
> There are a few *sources* of devices: dev_get, dev_get_by*. These
> should check and fail, using "try_dev_hold()" or something.
> Unfortunately auditing all the __dev_get_by* is quite a task, since
> it's used very widely (and I think, sometime erroneously).
> Completely untested patch below other patch.
> I need more time to digest your proposal in detail, Dave. Expect
> reply w/in 24 hours.
I'm digesting it as well 8)