[Top] [All Lists]

Re: purpose of the skb head pool

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: purpose of the skb head pool
From: Andi Kleen <ak@xxxxxxx>
Date: Tue, 29 Apr 2003 15:03:17 +0200
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030429135506.A22411@xxxxxx>
References: <20030429135506.A22411@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, Apr 29, 2003 at 01:55:06PM +0200, Christoph Hellwig wrote:
> [sorry, wrong Cc: the first time]
> net/core/skbuf.c has a small per-cpu pool to keep some hot skbufs around
> instead of returning them to the system allocator.  But if you loook
> at the slab allocator we'll have exactly that same code duplicated in
> there (see functions ac_data, __cache_alloc and kmem_cache_alloc in
> slab.c).  So is there some other reason why this pool is needed?

The code was added before slab grew an own per cpu allocator.

AFAIK it wasn't removed because the "extreme routing" people
like Jamal and Robert O. still saw small advantages, but it's 
probably worth rebenchmarking.


<Prev in Thread] Current Thread [Next in Thread>