netdev
[Top] [All Lists]

Re: [PATCH] af_pppox: create module infrastructure for protocol modules

To: acme@xxxxxxxxxxxxxxxx
Subject: Re: [PATCH] af_pppox: create module infrastructure for protocol modules
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 28 Apr 2003 23:00:34 -0700 (PDT)
Cc: mostrows@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, maxk@xxxxxxxxxxxx
In-reply-to: <20030429065419.GN25361@xxxxxxxxxxxxxxxx>
References: <20030429061227.GJ25361@xxxxxxxxxxxxxxxx> <20030428.222728.48508327.davem@xxxxxxxxxx> <20030429065419.GN25361@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
   Date: Tue, 29 Apr 2003 03:54:19 -0300

   Em Mon, Apr 28, 2003 at 10:27:28PM -0700, David S. Miller escreveu:
   > Although the idea is conceptually sound, you miss one crucial thing.
   > Such struct sock's reference _TWO_ modules, the "PPPOE" module
   > and the "PPPOX" module.
   
   But what is the problem? at pppox_sk_alloc time I bump the PPPOE
   module refcnt, making it safe, then it calls sk_alloc where it
   bumps the PPPOX module, making it safe as well, so I'm taking care
   of both PPPOE and PPPOX.

You're absolutely correct, I missed this.

I'll pull your changes, thanks.

<Prev in Thread] Current Thread [Next in Thread>