Re: Is a driver allowed to modify dev->flags?

[rask@xxxxxxxxxx (Rask Ingemann Lambertsen)]

Donald Becker wrote:
> On Tue, 1 Apr 2003, Rask Ingemann Lambertsen wrote:
> 
> > Is a network device driver allowed to modify dev->flags? For example:
> >
> > if (dev->flags & IFF_ALLMULTI)
> >         dev->flags |= IFF_PROMISC;
> 
> You must be looking at the atp.c driver, or a driver that cribbed from
> it.  (Is anyone still running a parallel port Ethernet device?!)

No, but I've seen such code in other Ethernet drivers and adopted it for my 
NE3200 driver.

> > I've found it to cause the IFF_PROMISC flag to stick when using
> > "tcpdump -p", which to my surprice sets the IFF_ALLMULTI flag.
> 
> Which driver are you using?

My experimental NE3200 driver, linux 2.4.20 and tcpdump from Redhat 7.3.

Regards,
Rask Ingemann Lambertsen