| To: | Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | NAPI note (was Re: lockups with 2.4.20 (tg3? net/core/dev.c|deliver_to_old_ones)) |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Fri, 14 Feb 2003 18:58:13 -0500 |
| Cc: | Pete Zaitcev <zaitcev@xxxxxxxxxx>, James Bourne <jbourne@xxxxxxxxxxxxx>, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <3E4D66DF.3040800@xxxxxxxxxxxxxxxx> |
| Organization: | none |
| References: | <3E4D66DF.3040800@xxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk |
Manfred Spraul wrote: It seems to be a generic NAPI restriction:The caller of netif_receive_skb() must not own a spinlock that is acquired from an interrupt handler. Thanks much for noticing this, Manfred. tg3 is definitely buggy in this regard. I've CC'd netdev as an FYI... We should probably patch NAPI_HOWTO for this note. I note that David pointed this out as an area for improvement, so he was already thinking in this direction anyway :)
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] zero rt_cache_stat statistics at init, Martin Josefsson |
|---|---|
| Next by Date: | Re: NAPI interrupt data, Jeff Garzik |
| Previous by Thread: | [PATCH] zero rt_cache_stat statistics at init, Martin Josefsson |
| Next by Thread: | Re: NAPI note, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |