netdev
[Top] [All Lists]

Re: skb_padto and small fragmented transmits

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: skb_padto and small fragmented transmits
From: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
Date: 07 Feb 2003 13:33:41 +0000
Cc: christopher.leech@xxxxxxxxx, netdev@xxxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20030206.144306.14966745.davem@xxxxxxxxxx>
Organization:
References: <BD9B60A108C4D511AAA10002A50708F20BA2AAE3@xxxxxxxxxxxxxxxxxxxxxx> <1044559328.4618.54.camel@xxxxxxxxxxxxxxxxxxxxx> <20030206.144306.14966745.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2003-02-06 at 22:43, David S. Miller wrote:
>    From: Chris Leech <christopher.leech@xxxxxxxxx>
>    Date: 06 Feb 2003 11:22:08 -0800
>    
>    OK, now I'm really getting confused.  Every other example I can find in
>    the networking code, and every scatter-gather capable driver, uses
>    skb->len as the full length and skb->len - skb->data_len as the length
>    of the first or linear portion.
>    
> Indeed, Alan you need to fix the skb_padto stuff to use
> skb->len, ignore the skb->data_len as skb->len is the
> full length.

Dave just fix it next time you touch the code and push it to Marcelo. It
doesnt affect the 2.2 backport so that will be ok



<Prev in Thread] Current Thread [Next in Thread>