| To: | bcrl@xxxxxxxxxx |
|---|---|
| Subject: | Re: [patch/bk] remove scm_cookie parameter to send/recvmsg |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Mon, 20 Jan 2003 21:14:16 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20030120161755.B23890@xxxxxxxxxx> |
| References: | <20030120161755.B23890@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
From: Benjamin LaHaise <bcrl@xxxxxxxxxx>
Date: Mon, 20 Jan 2003 16:17:55 -0500
+ memset(&scm, 0, sizeof(scm));
init_sync_kiocb(&iocb, NULL);
si = kiocb_to_siocb(&iocb);
si->sock = sock;
- si->scm = &si->async_scm;
+ si->scm = &scm;
si->msg = &kern_msg;
si->size = total_len;
si->flags = user_flags;
memset(si->scm, 0, sizeof(*si->scm));
We're now memset()'ing it twice? :) I think the first
memset isn't needed, and this makes the code consistent with
the other places this logic is duplicated.
Otherwise the patch is fine, please fix this stuff up and
resubmit, thanks.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: (usagi-users 02099) IPv6 packet forging, Mauro Tortonesi |
|---|---|
| Next by Date: | Re: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size), Alan |
| Previous by Thread: | [patch/bk] remove scm_cookie parameter to send/recvmsg, Benjamin LaHaise |
| Next by Thread: | non-growing tcp window size, Håkon Bugge |
| Indexes: | [Date] [Thread] [Top] [All Lists] |