netdev
[Top] [All Lists]

Re: [PATCH] tg3 intr masking update

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] tg3 intr masking update
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 21 Dec 2002 15:38:08 -0500
Cc: Manish Lachwani <manish@xxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <3E04CFBE.2060909@xxxxxxxxx>
References: <3E04CFBE.2060909@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2) Gecko/20021202
Additional note about this change,

The NAPI docs mention specific areas where races may occur, and coincedentally so do the tg3 docs. The tg3 docs suggest to me that in tg3_poll, after we unmask ints, we should
* flush the MMIO write
* check the status block for updates again
* tell tg3 to deliver to us an artificial interrupt just in case we raced [IMO preferred versus simply returning 'not-done' in tg3_poll retval]

But this is just a theory and not tested yet...


<Prev in Thread] Current Thread [Next in Thread>