| To: | kuznet@xxxxxxxxxxxxx, davem@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH RESEND] memory leak in ndisc_router_discovery |
| From: | Krishna Kumar <krkumar@xxxxxxxxxx> |
| Date: | Thu, 12 Dec 2002 11:05:43 -0800 (PST) |
| Cc: | netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi,
I had sent this earlier, there is a bug in router advertisement handling code,
where the reference (and memory) to an inet6_dev pointer can get leaked (this
leak can happen atmost once for each interface on a system which receives
invalid RA's). Below is the patch against 2.5.51 to fix it.
thanks,
- KK
-------------------------------------------------------------------------------
diff -ruN linux.org/net/ipv6/ndisc.c linux/net/ipv6/ndisc.c
--- linux.org/net/ipv6/ndisc.c Fri Nov 7 10:02:11 2002
+++ linux/net/ipv6/ndisc.c Fri Nov 8 14:37:27 2002
@@ -871,6 +871,7 @@
}
if (!ndisc_parse_options(opt, optlen, &ndopts)) {
+ in6_dev_put(in6_dev);
if (net_ratelimit())
ND_PRINTK2(KERN_WARNING
"ICMP6 RA: invalid ND option, ignored.\n");
-------------------------------------------------------------------------------
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: pci-skeleton duplex check, Donald Becker |
|---|---|
| Next by Date: | Re: pci-skeleton duplex check, Jeff Garzik |
| Previous by Thread: | Re: How to get the IPv6 address of next hop towards destination?, Zheng Jianping |
| Next by Thread: | Re: [PATCH RESEND] memory leak in ndisc_router_discovery, YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |