| To: | Andrew Morton <akpm@xxxxxxxxx> |
|---|---|
| Subject: | Re: [RFC][PATCH] net drivers and cache alignment |
| From: | "J.A. Magallon" <jamagallon@xxxxxxx> |
| Date: | Sun, 8 Dec 2002 00:52:55 +0100 |
| Cc: | "J.A. Magallon" <jamagallon@xxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <3DF28811.F6580BA6@xxxxxxxxx>; from akpm@xxxxxxxxx on Sun, Dec 08, 2002 at 00:45:21 +0100 |
| References: | <3DF2781D.3030209@xxxxxxxxx> <20021207.144004.45605764.davem@xxxxxxxxxx> <3DF27EE7.4010508@xxxxxxxxx> <3DF2844C.F9216283@xxxxxxxxx> <20021207233745.GE3183@xxxxxxxxxxxxxxxx> <3DF28811.F6580BA6@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On 2002.12.08 Andrew Morton wrote:
>"J.A. Magallon" wrote:
>>
>> #define __cacheline_start struct { } ____cacheline_aligned;
>
>That will generate a warning on faster^Wolder versions of gcc.
>
>mnm:/home/akpm> gcc t2.c
>t2.c:11: warning: unnamed struct/union that defines no instances
>t2.c:15: warning: unnamed struct/union that defines no instances
>mnm:/home/akpm> gcc -v
>Reading specs from /usr/local/lib/gcc-lib/i686-pc-linux-gnu/2.95.3/specs
>gcc version 2.95.3 20010315 (release)
>
And how 'bout this (do not have any gcc oldie available to test):
#define __cacheline_start union { int :0; } ____cacheline_aligned;
It passes gcc-3.2 -Wall...
I think it's nicer to insert __c_s than to go field by field marking
them...
--
J.A. Magallon <jamagallon@xxxxxxx> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.1 (Cooker) for i586
Linux 2.4.20-jam1 (gcc 3.2 (Mandrake Linux 9.1 3.2-4mdk))
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC][PATCH] net drivers and cache alignment, Andrew Morton |
|---|---|
| Next by Date: | Re: [RFC][PATCH] net drivers and cache alignment, Daniel Jacobowitz |
| Previous by Thread: | Re: [RFC][PATCH] net drivers and cache alignment, Andrew Morton |
| Next by Thread: | Re: [RFC][PATCH] net drivers and cache alignment, Daniel Jacobowitz |
| Indexes: | [Date] [Thread] [Top] [All Lists] |