Re: [PATCH] IPv6: Functions Clean-up

[Andras Kis-Szabo <kisza@xxxxxxxxxxxxxxxx>]

Hi,

> /*
>  * Taken from net/ipv6/ip6_output.c
>  * We should use the one there, but is defined static
>  * so we put this just here and let the things as
>  * they are now.
>  *
>  * If that one is modified, this one should be modified too.
>  */
> 
> So, the reason why the copy of route6_me_harder() 
> lives there is because net/ipv6/ip6_output.c has not been 
> exported it.
Ok, ok! I have not got problems with this any more! :)
It is even worse that the route6_me_harder() depends on the
CONFIG_NETFILTER option, so this function comes from the Netfilter. In
this case it is an unwanted code-duplication :(
 
> Is this something to do with parser of extension headers?
> Parser of extension headers is different thing, isn't it?
Yes, it is a different thing with different code.
 
Regards,

kisza

-- 
    Andras Kis-Szabo       Security Development, Design and Audit
-------------------------/        Zorp, NetFilter and IPv6
 kisza@xxxxxxxxxxxxxxxx /------------------------------------------->