netdev
[Top] [All Lists]

Re: [PATCHSET] Mobile IPv6 for 2.5.43

To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCHSET] Mobile IPv6 for 2.5.43
From: Ville Nuorvala <vnuorval@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 18 Oct 2002 02:52:48 +0300 (EEST)
Cc: ajtuomin@xxxxxxxxxxxxxxxxxxx, <davem@xxxxxxxxxx>, <kuznet@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <pekkas@xxxxxxxxxx>, <torvalds@xxxxxxxxxxxxx>, <jagana@xxxxxxxxxx>
In-reply-to: <20021018.021802.87011078.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 18 Oct 2002, YOSHIFUJI Hideaki / [iso-2022-jp] 吉藤英明 wrote:

> In article <20021017162624.GC16370@xxxxxxxxxxxxxxxxxxx> (at Thu, 17 Oct 2002 
> 19:26:25 +0300), Antti Tuominen <ajtuomin@xxxxxxxxxxxxxxxxxxx> says:
>
> [ipv6_tunnel]
>
> I think this is almost ok.
>
>   1. I believe s/ARPHRD_IPV6_IPV6_TUNNEL/ARPHRD_TUNNEL6/.

Ok by me! The comment of course says IPIP6 tunnel at the moment, but the
constant itself doesn't appear to be used anywhere.

>   2. Please put outer address to hardware address in dev.

The reason I haven't done this is that MAX_ADDR_LEN is just 8. Does anyone
have any objections against changing the value to 16?

>      Note: you need to modify SIOxxx ioctls too not to overrun!

Sorry, I'm not that familiar with ioctls, I just copied the basic
functionality from sit.c. Could you explain it a bit more thoroughly, so
even I with my thick skull understand what the problem is?


-Ville

--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@xxxxxxxxxx, phone: +358 (0)9 451 5257



<Prev in Thread] Current Thread [Next in Thread>