netdev
[Top] [All Lists]

Re: [patch] add iocb to network protocols

To: bcrl@xxxxxxxxxx
Subject: Re: [patch] add iocb to network protocols
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 10 Oct 2002 16:36:46 -0700 (PDT)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20021010194025.B13432@xxxxxxxxxx>
References: <20021010183528.A13432@xxxxxxxxxx> <20021010.162240.102769920.davem@xxxxxxxxxx> <20021010194025.B13432@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Benjamin LaHaise <bcrl@xxxxxxxxxx>
   Date: Thu, 10 Oct 2002 19:40:25 -0400

   On Thu, Oct 10, 2002 at 04:22:40PM -0700, David S. Miller wrote:
   > 
   > +#include <net/scm.h>      /* for sock_iocb */
   > 
   > What is this?
   
   The private area of an iocb for network operations contains a struct 
   scm_cookie.

I know this.  But the comment is wrong, when you say "for FOO"
next to an include that means "I'm including this to get the
definition of FOO".

Just delete the comment entirely, it really isn't needed.

Otherwise looks ok at first glance.


<Prev in Thread] Current Thread [Next in Thread>