netdev
[Top] [All Lists]

Re: [PATCH] IPv6: Miscellaneous clean-ups

To: yoshfuji@xxxxxxxxxxxxxx
Subject: Re: [PATCH] IPv6: Miscellaneous clean-ups
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 03 Oct 2002 10:36:17 -0700 (PDT)
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, usagi@xxxxxxxxxxxxxx
In-reply-to: <20021004.011315.05129566.yoshfuji@xxxxxxxxxxxxxx>
References: <20021004.011315.05129566.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
   Date: Fri, 04 Oct 2002 01:13:15 +0900 (JST)

   @@ -1187,7 +1187,7 @@
        ASSERT_RTNL();
    
        memset(&addr, 0, sizeof(struct in6_addr));
   -    addr.s6_addr[15] = 1;
   +    addr.s6_addr32[3] = __constant_htonl(0x00000001);
    
Do not use __constant_htonl() in runtime code, use htonl().
Arnaldo de Melo told you this the other day for another one
of your patches, so you must fix this kind of stuff up before
I'll apply any of your patches which have this problem.

Only use __constant_htonl() for compile time initialization of data
built into the kernel.

Otherwise I like you patch, please fix it up so I may apply it.


<Prev in Thread] Current Thread [Next in Thread>