| To: | Jason Lunz <lunz@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] 2.4.20-pre sundance.c update |
| From: | Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx> |
| Date: | Thu, 19 Sep 2002 01:11:41 -0400 |
| Cc: | netdev@xxxxxxxxxxx, Richard Gooch <rgooch@xxxxxxxxxxxxxxx>, becker@xxxxxxxxx, "Patrick R. McManus" <mcmanus@xxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> |
| Organization: | MandrakeSoft |
| References: | <20020828185612.GA14342@xxxxxxxxxxxxxxxxxx> <20020828231333.GA15183@xxxxxxxxxxxxxxxxxx> <200209190353.g8J3r5q28456@xxxxxxxxxxxxxxxxxxxxxxxx> <20020919041403.GA10527@xxxxxxxxxxxxxxxx> <3D89519C.1020809@xxxxxxxxxxxxxxxx> <20020919045621.GA11144@xxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826 |
Jason Lunz wrote: On Thu, Sep 19, 2002 at 12:25AM -0400, Jeff Garzik wrote:It still has several flaws that were pointed out, but this is the base from which I would like testing and patching to proceed. (also hopefully the flaws are minor in terms of general operation)what's the point of moving rx handling into rx_poll then running it in a tasklet? I've tested an older variant of that scheme from D-Link and it doesn't perform as well as my patch. It looks to me like an attempt to keep this version synced with the NAPI version of the driver, but it doesn't actually work very well. This is a merge and test point. The whole interrupt handler path is getting updated after this. (but thanks for the feedback, it is noted) The functional part of my patch was just taking the tx handling from d-link's driver and ditching the rx part. That and merging in the cleanups from Becker's driver; most notably ignoring the broken IntrRxDone bit. Maybe you could show me that in broken-out patches :) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | help !, den |
|---|---|
| Next by Date: | Re: [PATCH] 2.4.20-pre sundance.c cleanups, Richard Gooch |
| Previous by Thread: | Re: [PATCH] 2.4.20-pre sundance.c update, Jason Lunz |
| Next by Thread: | Re: [PATCH] 2.4.20-pre sundance.c update, Donald Becker |
| Indexes: | [Date] [Thread] [Top] [All Lists] |