netdev
[Top] [All Lists]

Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000

To: jgarzik@xxxxxxxxxxxxxxxx
Subject: Re: Early SPECWeb99 results on 2.5.33 with TSO on e1000
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 16 Sep 2002 16:43:43 -0700 (PDT)
Cc: dwmw2@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, todd-lkml@xxxxxxxxxxxxx, hadi@xxxxxxxxxx, tcw@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, pfeather@xxxxxxxxxx
In-reply-to: <3D866DD5.4080207@xxxxxxxxxxxxxxxx>
References: <3D86645F.5030401@xxxxxxxxxxxxxxxx> <20020916.160210.70782700.davem@xxxxxxxxxx> <3D866DD5.4080207@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
   From: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
   Date: Mon, 16 Sep 2002 19:48:37 -0400

   I dunno when it happened, but 2.5.x now returns EINVAL for all 
   file->file cases.
   
   In 2.4.x, if sendpage is NULL, file_send_actor in mm/filemap.c faked a 
   call to fops->write().
   In 2.5.x, if sendpage is NULL, EINVAL is unconditionally returned.
   

What if source and destination file and offsets match?
Sounds like 2.4.x might deadlock.

In fact it sounds similar to the "read() with buf pointed to same
page in MAP_WRITE mmap()'d area" deadlock we had ages ago.


<Prev in Thread] Current Thread [Next in Thread>